Improve lookup speed of GeoHandler (issue #1291) #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 14 files 14 suites 5h 40m 31s ⏱️ Results for commit 7390fd2. ♻️ This comment has been updated with latest results. |
andresailer
reviewed
Jul 22, 2024
andresailer
reviewed
Jul 22, 2024
Co-authored-by: Andre Sailer <andre.philippe.sailer@cern.ch>
andresailer
approved these changes
Jul 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
GeoHandler::i_collectby usingstd::setinstead ofstd::find(issue Increase in time consumption of the functionGeoHandler::i_collectafter PR #1277 #1291)ENDRELEASENOTES
Tried to add another container of
std::map<int, std::set<const TGeoNode*>>for the lookup purpose as @andresailer suggested in #1291. The simulation now seems running fine (as before #1277) even with a highly granular detector, but I'd appreciate suggestions from core developers if there is any.